Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correctness_gpu_allocation_cache test seems to be problematic under RustiCL/LLVMPipe #8335

Open
LebedevRI opened this issue Jun 29, 2024 · 2 comments

Comments

@LebedevRI
Copy link
Contributor

LebedevRI commented Jun 29, 2024

Running that test under HL_TARGET=host-opencl HL_JIT_TARGET=host-opencl OCL_ICD_VENDORS=rusticl.icd RUSTICL_ENABLE=llvmpipe,
(using Mesa 24.1.2-1 as present in debian sid) so that the OpenCL is actually run on the CPU,
that test seems to take a long time, over 5 minutes. I'm not sure if it ever finishes or not at all.
I'm not sure if this is a RustiCL bug, or the test is really just fundamentally ill-suited for CPU.

@LebedevRI
Copy link
Contributor Author

Ok, if looping 30 times instead of 300, it finishes in 525 seconds.

@LebedevRI
Copy link
Contributor Author

LebedevRI commented Jun 29, 2024

On an actual GPU it seems to finish rather quickly:

CC=clang-17 CXX=clang++-17 cmake -DCMAKE_BUILD_TYPE=Release -DHalide_REQUIRE_LLVM_VERSION=17 -DLLVM_DIR=/usr/lib/llvm-17/lib/cmake/llvm -DTARGET_WEBASSEMBLY=OFF  -DHalide_TARGET="host-opencl" ..
<...>
time HL_TARGET=host-opencl HL_JIT_TARGET=host-opencl OCL_ICD_VENDORS=rusticl.icd RUSTICL_ENABLE=radeonsi test/correctness/correctness_gpu_allocation_cache
Runtime with cache: 1.148489
Without cache: 1.165373
Success!

real    0m11.515s
user    0m9.156s
sys     0m0.183s

I'll forward to mesa.

Hm, but running it outside of deb build, manually, single test, it's not that slow either:

$ time HL_TARGET=host-opencl HL_JIT_TARGET=host-opencl OCL_ICD_VENDORS=rusticl.icd RUSTICL_ENABLE=llvmpipe test/correctness/correctness_gpu_allocation_cache
Runtime with cache: 7.260440
Without cache: 7.325961
Success!

real    1m1.768s
user    1m39.114s
sys     1m53.858s
$ time HL_TARGET=host-opencl HL_JIT_TARGET=host-opencl OCL_ICD_VENDORS=rusticl.icd RUSTICL_ENABLE=llvmpipe test/correctness/correctness_gpu_allocation_cache
Runtime with cache: 7.204123
Without cache: 7.236957
Success!

real    1m0.319s
user    1m39.195s
sys     1m44.556s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant