Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warnings for upcoming breaking changes in Sass #3718

Open
JaroCamphuijsen opened this issue Nov 19, 2024 · 2 comments
Open

Deprecation warnings for upcoming breaking changes in Sass #3718

JaroCamphuijsen opened this issue Nov 19, 2024 · 2 comments

Comments

@JaroCamphuijsen
Copy link

As of sass 1.80 the @import statement (still used in css/theme/template/theme.scss) will be deprecated alongside with several other changes. WIth the current version specification in the package.json I got several deprecation warnings when using reveal.js.

Would be good to get reveal.js ready for sass 1.80, or for the moment pin the version at a lower minor version.

Would be good to check for all breaking changes in Sass.

@JaroCamphuijsen
Copy link
Author

I'm happy to help, will try to open a PR in the coming weeks.

@hakimel
Copy link
Owner

hakimel commented Nov 19, 2024

Thanks but I've upgraded sass and fixed all deprecation warnings in the feature/vite branch. It's part of an all new build system for reveal.js 6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants