Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploaded HEIC photos are actually JPEG with HEIC file extensions #358

Open
alperozcetin opened this issue Jun 14, 2024 · 3 comments
Open

Comments

@alperozcetin
Copy link

Assessing the HEIC files uploaded with Seafile, file structure is not HEIC instead they are JPEG files with HEIC file extension. Using these files in other applications as HEIC results with an error, and files can be used as JPEG instead.

So Seafile iOS app does not upload the original raw HEIC images directly, rather still processes them as JPEG and uploads them as JPEG just with HEIC extension.

Assessed the files with several other tools as well, below is a summary.

The file starts with a JPEG header and includes typical JPEG metadata, including EXIF data. Extended analysis shows no HEIC-specific markers, confirming that the file is entirely a JPEG despite its .HEIC extension. Thus, the file is a misnamed JPEG file.

@lilthree
Copy link
Contributor

It will be fixed in the next version.

@afw384
Copy link

afw384 commented Nov 24, 2024

With app release version 2.9.31 I observed that the photo upload with disabled option "Upload HEIC" results in files with .JPG file ending and as HEIC file format.
Updated code is in file Pod/Classes/SeafUploadFile.m method convertHEICToJPEGAtURL line 664.

@henry9610
Copy link
Contributor

We truly appreciate you pointing this out. In the upcoming version, which will be released shortly, we have addressed the format issue to ensure consistency between the file extension and the actual file format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants