-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrades Living Document - Models #445
Comments
I am keen in order to help make it as easy as possible to use roost and [model name were working on] going forward as this is the last year of my PhD. I believe that standardising into something-like matminer which hopefully will have longer-term support from LBNL will help so if there's anything I can help with on this models initiative let me know. I have a re-implementation of cgcnn in the same repo as roost with an identical interface that could be used here for free if a standard model API is developed. https://github.com/gomes-lab/H-CLMP is the link for the CLMP model |
Thanks @CompRhys, I think RooSt will be a great addition to matminer. The way i am considering implementing this
Each model has a directory.
|
I've been thinking about this a little bit more and I think the most effective way to quickly add structure-based graphnets to matminer will be to wrap https://github.com/Open-Catalyst-Project/ocp/tree/master/ocpmodels/models - this way matminer would have access to more models for free as the OCP benchmarking suite is expanded over time. I would say the only issue you might have with this is that it neglects MegNET but you could have a separate wrapper or their package or perhaps the MegNET authors might want to add their model to the OCP benchmark. Separate to this I could look at whether it is possible to and standardise roost, crabnet and H-CLMP together. As far as I understand the primary difference between roost and crabnet are the choice of message passing function - they use QKV attention whereas mine mimics the attention mechanism in the GAT paper. The H-CLMP model duplicates a fair chunk of code from roost although I am not 100% sure how their model works yet. |
Rationale
In addition to featurizers and datasets, it might be useful if this code could access models in the same way datasets are downloaded.
This would extend the usage of matminer as a general purpose "toolbox" for materials science. It would also make matminer a curated resource which would hold many valuable models otherwise spread out across random GH repos and figshare accounts.
I imagine the majority of these would be graphnet models.
Example of usage
Predicting properties directly
For example:
Or:
Then:
Transfer learning for graphnet models
This would provide a consistent interface for getting embeddings from graphnet models to use downstream in other ML tasks, and does not need to weirdly go through BaseFeaturizer like CGCNN featurizer did.
Models to add
CLMP
CRABNet
Roost
MegNET
MODNet
CGCNNThe text was updated successfully, but these errors were encountered: