Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design: Create Style Guide - Dialog Boxes, Modals, Accordions Tabs, Tooltips, Infoboxes #1721

Closed
2 tasks
yiranshan opened this issue May 29, 2024 · 12 comments
Closed
2 tasks
Assignees
Labels

Comments

@yiranshan
Copy link
Member

yiranshan commented May 29, 2024

Overview

We need to create a Google deck of all the style guide pages on Figma and add a link to the wiki
This is a sub issue for Dialog Boxes, Modals, Accordions Tabs, Tooltips, Infoboxes

Action Items

  • Finalize this section for design system
  • update Style Guide Presentation

Resources/Instructions

@yiranshan
Copy link
Member Author

  1. Progress: edited notes from stakeholder
  2. Blockers: not sure if the edits are correct
  3. Availability: 4 hours next week
  4. ETA: next week
Screen Shot 2024-05-28 at 10 45 34 PM Screen Shot 2024-05-28 at 10 45 17 PM

@yiranshan yiranshan changed the title Create Style Guide - Dialog Boxes, Modals, Accordions Tabs, Tooltips Design: Create Style Guide - Dialog Boxes, Modals, Accordions Tabs, Tooltips May 30, 2024
@lbeatonn
Copy link
Member

lbeatonn commented Jun 17, 2024

Screen Shot 2024-06-17 at 4 42 36 PM

Emily's comment on Typography slide 7: "Are tool tips in the Paragraph 1 style?"

Resolved on Slide 8

@lbeatonn
Copy link
Member

Screen Shot 2024-06-17 at 4 43 57 PM

Emily's comment on Buttons slide 13: "At the top of the 2nd column, the "Edit Section" button is a style that we don't see outlined on the left of this slide. Please make sure there's an explanation of when to use that style, too."

Resolved on slide 14 with that button style removed

@lbeatonn
Copy link
Member

Screen Shot 2024-06-17 at 4 53 55 PM

Emily's comment on Icons slide 18: "I think there was recent discussion of changing the icon library... did that happen, and if so, are these all the new icons for the app?"

@marlenamellody changed the icons, but the status is Pending Approval from dev team

@lbeatonn
Copy link
Member

lbeatonn commented Jun 17, 2024

Screen Shot 2024-06-17 at 4 57 29 PM

Emily's comment on Tooltips slide 28

Resolved on Slide 29

@lbeatonn
Copy link
Member

Screen Shot 2024-06-17 at 4 59 20 PM

Emily's comment on Headers slide 37 "The Logged-in header may be the wrong image (it still says "Login")"

Resolved on Slide 38

@yiranshan yiranshan assigned NilakshiS and unassigned yiranshan Jun 20, 2024
@lbeatonn
Copy link
Member

Added caption for tooltip in typography - Slide 9 is new slide Comment

@hackforla hackforla deleted a comment from Parisajf Jun 21, 2024
@hackforla hackforla deleted a comment from Parisajf Jun 21, 2024
@NilakshiS NilakshiS added the pbv: design all issues for design roles label Aug 8, 2024
@NilakshiS
Copy link
Member

Added the different infoboxes currently on the dev site (as of 08/21/24) to the style guide:
Link to "Infoboxes" on Figma
Infoboxes

Link to "Infoboxes - 2" on Figma
Infoboxes - 2

@NilakshiS
Copy link
Member

Made the following changes to infoboxes to match the style guide prescribed typography and colors:

  • Warning infobox: changed background color to "Error background" and title font to "Heading 1".
  • Guide infobox: changed background color to "Greyscale/Light Gray", added a bottom padding.
  • Target points infobox: changed font to "Paragraph" style.
  • Points Notification infobox: Changed font to "Subheading" style, removed drop shadow, reduced container size to fit-content.

Link to "Infoboxes - iteration 2" on Figma
Infoboxes - interation 2

Link to "Infoboxes - 2 - iteration 2" on Figma
Infoboxes - 2 iteration 2

@NilakshiS NilakshiS changed the title Design: Create Style Guide - Dialog Boxes, Modals, Accordions Tabs, Tooltips Design: Create Style Guide - Dialog Boxes, Modals, Accordions Tabs, Tooltips, Infoboxes Aug 22, 2024
@NilakshiS
Copy link
Member

Made the following changes to infoboxes:

  • Added another example of points notification infobox
  • Points Notification Infobox, target not acheived: Changed the color of warning icon to "Critical"
  • Added another example of notification infobox, changed the text explanation

Link to "Infoboxes - 2 - iteration 2" on Figma
Infoboxes - 2 iteration 2

Added these to the style guide presentation: Link to the infoboxes slide

@ExperimentsInHonesty
Copy link
Member

Changes accepted by stakeholder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: On Dev - not yet pushed to Prod
Development

No branches or pull requests

5 participants