Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validators Response Limit #15

Open
kamilstakingrewards opened this issue Dec 9, 2024 · 0 comments
Open

Validators Response Limit #15

kamilstakingrewards opened this issue Dec 9, 2024 · 0 comments

Comments

@kamilstakingrewards
Copy link

Hello, I've noticed that the https://undexer.hack.bg/v4/validators request returns a maximum of 100 validators per page/request, and then you have to use 'offset'. Is this really necessary for such a small data set? Namada will have a maximum of 250 validators, so presenting them all at once won't be resource-consuming. This way you won't have to hassle with pagination and offset. To be clear, I'm not talking about removing 'limit' and 'offset' because they can be useful in certain cases. I would just as standard, without any parameters, return all validators.

https://github.com/hackbg/undexer/blob/v4/swagger.yaml
/validators:
get:
summary: Get paginated list of validators, optionally filtered by state
parameters:
- {name: state, in: query, required: true, schema: {type: string, enum: [BelowThreshold, BelowCapacity, Jailed, Consensus, Inactive]}, description: "State of the validators"}
- {name: limit, in: query, required: false, schema: {type: integer}, description: "Number of validators to return"}
- {name: offset, in: query, required: false, schema: {type: integer}, description: "Offset for pagination"}

PS Creating this issue after a discord chat with Daniel, @danielmandragora

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant