Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation failure due to OGLCompiler being removed from glslang and shaderc #226

Open
rxguy opened this issue Dec 5, 2023 · 2 comments

Comments

@rxguy
Copy link

rxguy commented Dec 5, 2023

As described in the title, see:

https://github.com/KhronosGroup/glslang/commit/6be56e45e574b375d759b89dad35f780bbd4792f

and

https://github.com/google/shaderc/commit/40bced4e1e205ecf44630d2dfa357655b6dabd04

I can build successfully with this small patch.


--- libplacebo/src/glsl/meson.build 2023-12-02 20:48:51.445273381 -0400
+++ libplacebo_patch/src/glsl/meson.build   2023-12-05 10:56:49.083295970 -0400
@@ -44,7 +44,7 @@ elif not glslang_req.disabled()
         # Always required for static linking
         cxx.find_library('MachineIndependent', required: true, static: true),
         cxx.find_library('OSDependent',        required: true, static: true),
-        cxx.find_library('OGLCompiler',        required: true, static: true),
+#        cxx.find_library('OGLCompiler',        required: true, static: true),
         cxx.find_library('GenericCodeGen',     required: true, static: true),
         # SPIRV-Tools are required only if optimizer is enabled in glslang build
         cxx.find_library('SPIRV-Tools',        required: false, static: true),

libplacebo-OGLCompiler.patch

Thanks,
Dale

@jfe1205
Copy link

jfe1205 commented Jan 26, 2024

The issue remains and probably needs to be posted on Videolan to receive any attention.

@kwizart
Copy link

kwizart commented Jul 10, 2024

OGLCompiler (and some others) was turned into required: false
So this issue is solved with current release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants