Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancing Ruby script #25

Open
KINGSABRI opened this issue Feb 27, 2017 · 0 comments
Open

Enhancing Ruby script #25

KINGSABRI opened this issue Feb 27, 2017 · 0 comments

Comments

@KINGSABRI
Copy link

KINGSABRI commented Feb 27, 2017

Hi,
Thanks for making this extension available. I've some points on the generated Ruby script

  1. No need to require uri since it gets required once you require net/http
  2. Put set_form_data data in a separate hash variable, let's call form_data for better looking and it's easier to manipulate
  3. Beautify the hash
form_data = {
    "ABCD" => "123", "ABCD" => "123",
    "ABCD" => "123", "ABCD" => "123",
    "ABCD" => "123", "ABCD" => "123"
}

Thanks again for this awesome extension

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants