-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net/context and httptrace support #17
Comments
Thanks for the proposal, in fact, I'm aware about As temporal solutions, I think you can write your own plugin in order to expose and encapsulate a Just one question: what are you missing from Feel free to fork and share your changes, I would appreciate if you can do that them in order to find potential better ideas for future implementations. |
Great to hear that you are willing to consider One of the reasons why I need it, instead of If I come up with anything I will make sure to send PR, so we can iterate over it to come to acceptable solution. |
Thanks for the clarification, that's was the most practical need for me as well. I would suggest giving it a try exposing the |
Go stdlib |
|
Hi, I know it's an old issue, but I think my question is related. :) ctx, _ = context.WithTimeout(context.Background(), 5 * time.Second)
ctx = context.WithValue(ctx, gcontext.Key, req.Context.GetAll())
req.Context.Request = req.Context.Request.WithContext(ctx) Is it ok or am I missed something in the documentation? |
First of all, great library. I really like design decisions and usability of it.
I do have some things that I miss and that I can not write plugin for. Although
gentleman.context.Context
is useful, I would really like to have support for net/context, especially now that it is part of standard library andnet.Request
has support for it.Also, if context is added, following part should be easy, but I would also like to have some kind of support for httptrace for debugging purposes (also part of standard library since golang 1.7).
Do you have any plans of adding support for these things? And if yes, in which direction were you thinking of going?
I have experimented a bit locally and I have had some progress, but changes that I have made are not backward compatible, so I am not sure if PR would be accepted (not that I have something worthy or PR, it was just experiment).
Thanks.
The text was updated successfully, but these errors were encountered: