Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

max zoom is too limited #100

Open
DubbleClick opened this issue Aug 19, 2024 · 3 comments
Open

max zoom is too limited #100

DubbleClick opened this issue Aug 19, 2024 · 3 comments
Labels
bug Something isn't working frontend

Comments

@DubbleClick
Copy link
Member

especially noticeable in Tyria - can't zoom out further than the max width being reached. this means that on a fully zoomed out tyria map, you can only see about a third of the map

@DubbleClick DubbleClick added bug Something isn't working frontend labels Aug 19, 2024
@AlexMacocian
Copy link
Collaborator

Related to this #85

Zoom levels are based on the tiles that we have. I've limited the max zoom level so that you can't zoom out enough that you have black bars on the sides of the screen.

I don't know how to reconcile these two issues without redoing the tiles (and even then, it would still depend on screen size). We'd have to redo the tiles and all the coordinates of all the markers

@DubbleClick
Copy link
Member Author

Having black bars on the sides of the screen is fine, having black bars on BOTH top/bottom and left/right should not be possible. If the library isn't capable of that, Then fuck it, just limit it to zzoom levels that mostly prevent blackbars on both sides.

@AlexMacocian
Copy link
Collaborator

Feel free to play with it. The jsons in the /data/ folder define the continents. In there I set up a max zoom and a min zoom property. Play with those until you get what you think should be the ideal effect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend
Projects
None yet
Development

No branches or pull requests

2 participants