Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto enable cons on dungeon entry (if someone in pty has correct quest) #1288

Open
FrenchGucho opened this issue Dec 4, 2024 · 2 comments
Open
Labels
feature request Request for a new feature Won't Implement Decision to not implement, reason stated

Comments

@FrenchGucho
Copy link

Now that GWCA is gone, could you add this feature to toolbox? I had added this to my own personal version however TB can no-longer be built due to the lack of GWCA access. This feature works well with auto disabling cons on dungeon completion as you may not want to manually enable cons every time you zone into the dungeon. You can check if the dungeon has changed due to someone in the party having the quest and enable cons accordingly.

This would prevent wasted cons due to rezoning for quest, as well as improve the smoothness of the other feature I requested of auto disabling on dungeon completion making the cons toggle for dungeons an after-thought for the user. Admittedly this feature is a bit more complicated but its a life changer.

@FrenchGucho FrenchGucho changed the title Auto enable cons on dungeon entry Auto enable cons on dungeon entry (if dungeon activated by someone having quest) Dec 4, 2024
@FrenchGucho FrenchGucho changed the title Auto enable cons on dungeon entry (if dungeon activated by someone having quest) Auto enable cons on dungeon entry (if someone in pty has correct quest) Dec 4, 2024
@FrenchGucho
Copy link
Author

FrenchGucho commented Dec 4, 2024

I would have made a pull request for both features however due to my lack of toolbox/GWCA knowledge, my implementation of this specific feature was a bit different as I found it much easier to simply check if the player moved from !dungeon -> dungeon and repurposed this in-town IMS bit of code.

    const GW::Agent* _player = GW::Agents::GetControlledCharacter();
    if (!_player || _player->move_x == 0.0f && _player->move_y == 0.0f)

It was a quick and dirty solution but with the new potential inability to make/test these features on my own going forward, figuring out how to do it the right way did not seem worthwhile.

@3vcloud
Copy link
Member

3vcloud commented Dec 7, 2024

Theres a lot of code debt involved to add checks and balances for every single dungeon for this feature to be feasible. For this reason, and the availability of hotkeys and the pcons ui interface to easily toggle pcons on or off manually, I don't think this is worth implementing

@3vcloud 3vcloud added feature request Request for a new feature Won't Implement Decision to not implement, reason stated labels Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature Won't Implement Decision to not implement, reason stated
Projects
None yet
Development

No branches or pull requests

2 participants