Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check in-game timestamp setting when loading to avoid overriding gw setting #1285

Open
Demne opened this issue Nov 27, 2024 · 1 comment
Open

Comments

@Demne
Copy link

Demne commented Nov 27, 2024

Hello,

With version 6.25, as soon as i open TB++ the option: Options [F11] -> General -> Show chat timestamps is automatically disabled.

@callmepsywolf
Copy link

callmepsywolf commented Nov 29, 2024

Depends on which should be the leading system I guess. If GW should be the leading system on initial load then
GW::Chat::ToggleTimestamps(show_timestamps); should be removed. Otherwise it seems like it's working as intended. Set the option for Show chat timestamps in the "Chat Settings" Module and it shouldn't turn off again on initial load as it should be saved when leaving TB.

ChatSettings.cpp

void ChatSettings::LoadSettings(ToolboxIni* ini)
{
    ToolboxModule::LoadSettings(ini);

    LOAD_BOOL(show_timestamps);
    LOAD_BOOL(show_timestamp_24h);
    LOAD_BOOL(show_timestamp_seconds);
    LOAD_BOOL(hide_player_speech_bubbles);
    LOAD_BOOL(npc_speech_bubbles_as_chat);
    LOAD_BOOL(redirect_npc_messages_to_emote_chat);
    LOAD_BOOL(redirect_outgoing_whisper_to_whisper_channel);
    LOAD_BOOL(openlinks);
    LOAD_BOOL(auto_url);

    timestamps_color = Colors::Load(ini, Name(), VAR_NAME(timestamps_color), Colors::RGB(0xc0, 0xc0, 0xbf));
    GW::UI::SetOpenLinks(openlinks);
    GW::Chat::ToggleTimestamps(show_timestamps);
    GW::Chat::SetTimestampsColor(timestamps_color);
    GW::Chat::SetTimestampsFormat(show_timestamp_24h, show_timestamp_seconds);
}

@3vcloud 3vcloud changed the title Deactivation of chat timestamps Check in-game timestamp setting when loading to avoid overriding gw setting Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants