Add Gitub Category #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-007/gurkbot into feature/github-category
|
Closing #11 |
vivax3794
added
area: commands
vivekashok1221
requested changes
Jan 8, 2021
|
Fixed merged conflict |
|
@codephile1221 Ok , thanks for the review, will mention those changes in the next commit. |
|
I wouldn't mind if you make multiple commits for the changes. |
1. Use None instead 2. Add Error Embed Cog which takes random title from constants.py 3. Combine get_repo for channel into one line.
vivekashok1221
requested changes
Jan 11, 2021
vivekashok1221
requested changes
Jan 11, 2021
1. Use MissingReqiuredArguments and let the error handler handle it. 2. Take channel as argument in issues helper instead of the id. 3. Remove redudant code. 4. Fix source link. 5. Remove the docstrings while sending code.
…rate emebed ; Allow user/prepository in _issues.py ; get embed back to _source.py
vivekashok1221
requested changes
Jan 13, 2021
vivekashok1221
requested changes
Jan 13, 2021
1. Change issue usage to >user>/<repo> 2. Add better docstring for class Github. 3. Remove redundant code like instead of raising error if none, make it a required argument.
vivekashok1221
requested changes
Jan 17, 2021
Co-authored-by: Vivek Ashok <[email protected]>
Co-authored-by: Vivek Ashok <[email protected]>
|
Done. |
vivekashok1221
requested changes
Jan 17, 2021
Co-authored-by: Vivek Ashok <[email protected]>
uncomfyhalomacro
approved these changes
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.