Should TileAnimation have the @XmlRootElement annotation?

[nightm4re94]

^{This post has been migrated automatically from the old LITIENGINE forum (2018 - 2022).
Posted: 2019-04-12 22:12:19
User: TheRamenChef [] (age: 1441 days 🔥; posts: 5)}
A while back, I removed a whole bunch of ~~~~@XmlRootElement annotations from the TMX API in this commit: 4d3a500
In a recent commit by @steffen however, that annotation was added back to the Animation class with no explanation given. The class was also renamed to ~~~~TileAnimation, though I don't have any objections to the rename.
I originally removed the annotation because the annotation is supposed to be used for root elements, which animations are not, as I explained in the commit description. Is there a reason why animations should have the ~~~~@XmlRootElement annotation?

[nightm4re94]

^{This post has been migrated automatically from the old LITIENGINE forum (2018 - 2022).
Posted: 2019-04-13 10:46:27
User: steffen [Admin 👑, Mod 🔧] (age: 1568 days 🔥; posts: 100)}
I think you're right here. My intention was to enforce the XML name "animation" if the class is serialized, independent from the context in which it's used. But right now, the ~~~~TileAnimation is only used in the context of a ~~~~TilesetEntry which defines "animation" as the field name. So in the current state, the ~~~~@XmlRootElement is not really necessary. Thank's for pointing that out.