New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`BoundBox.is_inside` not working correctly #827

Open

jdegenstein opened this issue Dec 19, 2024 · 0 comments

Labels

bug

Milestone

Not Gating Releas...

Collaborator

jdegenstein commented Dec 19, 2024

bb = Compound([Vertex(1,1,1),Vertex(2,2,2)]).bounding_box()
bb2 = Compound([Vertex(0,0,0),Vertex(-1,-1,-1)]).bounding_box()
print(bb)
print(bb2)
print(bb.is_inside(bb2))

Returns:

bbox: 1.0 <= x <= 2.0, 1.0 <= y <= 2.0, 1.0 <= z <= 2.0
bbox: -1.0 <= x <= 0.0, -1.0 <= y <= 0.0, -1.0 <= z <= 0.0
True

Also, it looks like the False result was never tested in test_direct_api.py

The text was updated successfully, but these errors were encountered:

jdegenstein added this to the Not Gating Release 1.0.0 milestone

jdegenstein mentioned this issue

Fix BoundBox.is_inside #828

Open

jdegenstein added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment