Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Save Location #175

Open
puppykickr opened this issue Sep 22, 2019 · 12 comments
Open

Custom Save Location #175

puppykickr opened this issue Sep 22, 2019 · 12 comments

Comments

@puppykickr
Copy link

General information

  • App version:
    F-Droid, version 1.6.2
  • System:
    ZTE 558VL, 7.1.1

Description

It would be nice to have user control over where the memes are to be saved.
It would be even nicer if the SD card was included as an option.

Log

N/A

@gsantner
Copy link
Owner

I thought thats already implemented, but is not :D

@puppykickr
Copy link
Author

This would be a nice help for me, and a great help for another user I am aquainted with through another app.

Thank you in advance.

@gsantner gsantner changed the title (Feature Request) Please Allow User Defined Save Location Custom Save Location Sep 24, 2019
@kdhalbert13
Copy link

I can take this one if you still need help.

@gsantner
Copy link
Owner

gsantner commented Oct 1, 2019

@kdhalbert13
Sure, go for it :).

Please use the FilesystemViewerDialog from here for folder selection, you can copy over all required files.
You can lookup how it works by Markor's SettingsActivity, preference.xml and AppSettings.

@gsantner
Copy link
Owner

gsantner commented Oct 8, 2019

@kdhalbert13
Thanks!

Please make a pull request as soon as you start, that makes it easier to detect bigger issues and you don't do certain things multiple times :).

@gsantner
Copy link
Owner

gsantner commented Feb 9, 2020

Ok I'm sad to see that no work was done 😞

@woeisme
Copy link

woeisme commented Oct 14, 2020

I've noticed that MemeTastic doesn't honor the 'change storage' app management option from within Android 10.
This would be the most common way users have to move it to SD storage.

@puppykickr
Copy link
Author

@woeisme
That would do nothing for those of us not running Android 10.

@gsantner
Copy link
Owner

As Android restricts "public"/"external storage" write & read with every Android release more and more, probably this will happen:

  • When < Android 10, stays as is, Pictures folder
  • When >= Android 10, app storage (that one can always be accessed & written), with easy methods of sharing pictures.

@SebiderSushi
Copy link

What is planned for the "Save Meme" feature on android 10 and above?
Are there any plans to play along with MediaStore at all? If so, how much is the gap from storing single memes via MediaStore to managing a templates folder in the internal shared storage?

Apart from MediaStore support, i think keeping the templates folder within MemeTastics private app storage should be acceptable. When offering an import/export feature that accepts or returns a zip file with template images it would sound intuitive enough from my perspective.

@gsantner
Copy link
Owner

What is planned for the "Save Meme" feature on android 10 and above?

There is no code contributor since years and I myself don't plan to waste too much time on this issue on this project. Google intentionally breaks file access - with such a small project I don't have the willingness to migrate year for year to the new favourite special document access Google wishes for that year.

To come back to the question, exactly what I said above - (private) app storage.

@SebiderSushi
Copy link

Fair enough. Thank you for breaking it down for us!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants