Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll out cluster update command in kubergrunt should validate PodDisruptionBudgets #5

Open
yorinasub17 opened this issue Jan 14, 2019 · 1 comment
Labels
enhancement New feature or request needs design We need to flesh out the design before we can resolve the issue

Comments

@yorinasub17
Copy link
Contributor

Currently kubergrunt does not implement any checks for minimal downtime features to be implemented on the Kubernetes resources deployed on the cluster. As part of the rollout command, we should validate that the disruption control features (readiness probes and Pod Disruption Budgets) are implemented on the deployed resources before continuing with the rollout.

@rhoboat
Copy link
Contributor

rhoboat commented Apr 12, 2022

Implementation idea, use a new flag like eks deploy --with-validation, to ensure that deploy will respect downtime features (like readiness probes and Pod Disruption Budgets). If none of these are set, and --with-validation is given, it should interrupt the command with a warning and ask if you want to proceed.

@rhoboat rhoboat added the needs design We need to flesh out the design before we can resolve the issue label Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs design We need to flesh out the design before we can resolve the issue
Projects
None yet
Development

No branches or pull requests

3 participants