Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'ingressClassName' instead deprecated annotation "kubernetes.io/ingress.class" #189

Open
nadiia-caspar opened this issue Jun 13, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@nadiia-caspar
Copy link
Contributor

nadiia-caspar commented Jun 13, 2024

Describe the solution you'd like
I've noticed the warning during a chart deployment:

W0612 15:00:09.676081    1973 warnings.go:70] annotation "kubernetes.io/ingress.class" is deprecated, please use 'spec.ingressClassName' instead

The kubernetes.io/ingress.class annotation is deprecated since Kubernetes v1.18 , also a deprecation notes in AWS load balancer.

So we might add the spec.ingressClassName field to the Ingress template.

@nadiia-caspar nadiia-caspar added the enhancement New feature or request label Jun 13, 2024
@ryehowell
Copy link
Contributor

Hi @nadiia-caspar, thanks for opening this issue!

This should def be updated. We will get it into the backlog for one of the upcoming sprints. We do welcome PR's as well if you are interested in contributing an update for this 😄

@nadiia-caspar
Copy link
Contributor Author

@ryehowell i could try to create a PR. But would need so clarification: do you support backward compatibilities? Should the previous way with annotations be supported?

@ryehowell
Copy link
Contributor

Hi @nadiia-caspar, we always try to maintain as much backwards compatibility as possible, whenever and wherever possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants