Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ubuntu version changes #66

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Ubuntu version changes #66

wants to merge 2 commits into from
+36 −75

Conversation

gcagle3
Copy link
Contributor

@gcagle3 gcagle3 commented Jun 27, 2024 •
edited
Loading

Description

Removes EOL Ubuntu 16.04 and 18.04 tests. Adds tests for Ubuntu 22.04.

TODOs

Please ensure all of these TODOs are completed before asking for a review.

  • Ensure the branch is named correctly with the issue number. e.g: feature/new-vpc-endpoints-955 or bug/missing-count-param-434.
  • Update the docs.
  • Keep the changes backward compatible where possible.
  • Run the pre-commit checks successfully.
  • Run the relevant tests successfully.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.

Related Issues

Fixes #65

@gcagle3 gcagle3 requested a review from brikis98 as a code owner June 27, 2024 19:59
@justin-octo
Copy link
Contributor

justin-octo commented Jun 27, 2024 •
edited
Loading

Would it be worth adding a test for each Ubuntu version to test what is the default when NO version of IMDS is declared?

Something like:

bats_ubuntu2404_imds_default

... with no GRUNTWORK_BASH_COMMONS_IMDS_VERSION declared.

@gcagle3
ubuntu version updates
6d5a31b 
- Remove ubuntu 16.04/18.04
- Add support for ubuntu 22.04
- Add test for no IMDS version specified
@gcagle3
Copy link
Contributor Author

gcagle3 commented Jun 27, 2024

Would it be worth adding a test for each Ubuntu version to test what is the default when NO version of IMDS is declared?

Something like:

bats_ubuntu2404_imds_default

... with no GRUNTWORK_BASH_COMMONS_IMDS_VERSION declared.

This was a great suggestion that actually replicated the error you were seeing in testing:

bats_ubuntu2204_no_imds-1  | # actual:   2024-06-27 20:57:34 [ERROR] [bats-exec-test] '' is not a valid value for Instance Metadata service version in use. Must be one of: [1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brikis98 brikis98 Awaiting requested review from brikis98 brikis98 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Ubuntu 16 and 18 test cases
2 participants
@gcagle3 @justin-octo