Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠️ Refactor: use vue-svg-loader for all SVG icons #84

Open
dlqqq opened this issue Nov 5, 2020 · 0 comments
Open

🛠️ Refactor: use vue-svg-loader for all SVG icons #84

dlqqq opened this issue Nov 5, 2020 · 0 comments
Assignees
@dlqqq
Labels
Domain: Dev Experience This issue pertains to a developer's emotions and attitudes when building Grey Software. Role: Software Engineer Uses technology to design, develop, test, and maintain creative software solutions.

Comments

@dlqqq
Copy link
Contributor

dlqqq commented Nov 5, 2020

Motivation 🏁

vue-svg-loader is currently being introduced in PR #83. It treats all SVG files as Vue components, and calls svgo in the build step to optimize all SVGs, greatly improving load times. This means cleaner code (no more disgusting 10-line long SVGs in the middle of Vue components) and faster load times for the end-user.

Describe your refactoring solution 🛠️
@dlqqq dlqqq added Domain: Dev Experience This issue pertains to a developer's emotions and attitudes when building Grey Software. Role: Software Engineer Uses technology to design, develop, test, and maintain creative software solutions. labels Nov 5, 2020
@dlqqq dlqqq mentioned this issue Nov 5, 2020
Merged
@dlqqq dlqqq self-assigned this Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dlqqq dlqqq

Labels
Domain: Dev Experience This issue pertains to a developer's emotions and attitudes when building Grey Software. Role: Software Engineer Uses technology to design, develop, test, and maintain creative software solutions.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dlqqq