-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post practice session report #48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep up the good work!
}; | ||
</script> | ||
|
||
<style scoped> | ||
.mobile-container { | ||
width: 420px; | ||
max-height: 85%; | ||
min-height: 85%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What were you trying to fix with this?
@@ -107,6 +96,15 @@ export const actions: ActionTree<PracticeState, any> = { | |||
context.commit(PracticeMutations.RESET_PRACTICE_SESSION) | |||
}, | |||
skipQuestion(context) { | |||
const questionReport = { | |||
question: context.state.question.infix, | |||
answer: "-", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not an empty string here?
}, | ||
createQuestionReport(state: PracticeState) { | ||
|
||
var added = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/find for more concise code
PR Notes
|
No description provided.