Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basics documentation example incorrect: sqrt >> isEven >> not #15

Closed
lue-bird opened this issue Aug 8, 2022 · 2 comments · Fixed by #57
Closed

Basics documentation example incorrect: sqrt >> isEven >> not #15

lue-bird opened this issue Aug 8, 2022 · 2 comments · Fixed by #57
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed

Comments

@lue-bird
Copy link

lue-bird commented Aug 8, 2022

elm/core#1097

@robinheghan robinheghan added documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed labels Sep 17, 2022
@alexislozano
Copy link
Contributor

@lue-bird What do you think replacing 'sqrt' in the docs with round? round takes a Float and returns an Int. So it would make the example compilable:

round >> isEven >> not

@lue-bird
Copy link
Author

lue-bird commented Oct 20, 2022

Sounds good, maybe embedded in something like

[ 1.2, 3.7, -5.2, -10 ]
    |> Array.filter (round >> isEven >> not)
--> [ 1.2, -5.2 ]

(Btw, pinging me is fine but I have no more say or insight than you. I just happen to have been allowed to port all elm/ issues over)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants