Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes #269

Open
vincerubinetti opened this issue Jul 24, 2024 · 0 comments · May be fixed by #274
Open

Minor fixes #269

vincerubinetti opened this issue Jul 24, 2024 · 0 comments · May be fixed by #274
Labels
bug Something isn't working enhancement New feature or request

Comments

@vincerubinetti
Copy link
Collaborator

vincerubinetti commented Jul 24, 2024 •
edited
Loading

Running list of minor things to fix:

  • Why are on-pull-request and on-push .yml instead of .yaml? I vaguely recall github inconsistently requiring .yml vs .yaml in different cases, but I'm not sure this is one of them. .yaml is canonically what you're supposed to use according to YAML, so I've tried to always use that.
  • Add flex-shrink: 0 to _styles/header.scss .logo and width: unset
  • Add <details> styling.
  • Update docs to note that in periodic citation updates, when we automatically open a pr, we can't automatically trigger a PR preview build.
@vincerubinetti vincerubinetti added enhancement New feature or request bug Something isn't working labels Jul 24, 2024
@vincerubinetti vincerubinetti changed the title CSS fixes Minor fixes Jul 26, 2024
@vincerubinetti vincerubinetti mentioned this issue Jul 29, 2024
Closed
@vincerubinetti vincerubinetti linked a pull request Aug 7, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v1.3.0 greenelab/lab-website-template
1 participant
@vincerubinetti