Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(design): daff-map-get function #3358

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

feat(design): daff-map-get function #3358

wants to merge 9 commits into from

Conversation

gracetxgao
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: #3309

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@gracetxgao gracetxgao requested a review from a team as a code owner December 10, 2024 21:15
@xelaint
Copy link
Member

xelaint commented Dec 11, 2024 •
edited by damienwebdev
Loading

@damienwebdev Is the daff-map-get function is also supposed to be able to replace SCSS's map get function?

@xelaint xelaint added the package: design @daffodil/design label Dec 11, 2024
@gracetxgao gracetxgao requested review from a team as code owners December 13, 2024 20:41
@xelaint
Copy link
Member

xelaint commented Dec 16, 2024 •
edited by damienwebdev
Loading

@damienwebdev @gracetxgao

Is the daff-map-get function is also supposed to be able to replace Angular's map get function?

I expect the palettes to be using daff-map-get as well? (i.e. $primary, $secondary, $tertiary). It's still confusing that some use SCSS's map while some use daff-map-get.

Currently:

$primary: map.get(daff-theme.$theme, primary);
$secondary: map.get(daff-theme.$theme, secondary);
$tertiary: map.get(daff-theme.$theme, tertiary);
$base: daff-theme.daff-map-get($theme, 'core', 'base');
$base-contrast: daff-theme.daff-map-get($theme, 'core', 'base-contrast');

Expect:

$primary: daff-theme.daff-map-get($theme, primary);
$secondary: daff-theme.daff-map-get($theme, secondary);
$tertiary: daff-theme.daff-map-get($theme, tertiary);
$base: daff-theme.daff-map-get($theme, 'core', 'base');
$base-contrast: daff-theme.daff-map-get($theme, 'core', 'base-contrast');

@xelaint
Copy link
Member

xelaint commented Dec 17, 2024

@gracetxgao

Can you update all $primary, $secondary, $tertiary, $info, $warn, $critical, and $success values to use the daff-map-get function?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xelaint xelaint xelaint requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
package: design @daffodil/design
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] Create daff-map-get function
2 participants
@gracetxgao @xelaint