Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to generate images on branches #7

Open
iozz opened this issue Jun 18, 2020 · 1 comment
Open

Unable to generate images on branches #7

iozz opened this issue Jun 18, 2020 · 1 comment

Comments

@iozz
Copy link

iozz commented Jun 18, 2020

I've managed to setup the action for the master branch, but I'd like to also generate images on other branches, so that my reviewers can read our documentation with consistent diagrams during their reviews.

My workflow is the following:

name: Generate diagrams
on: push
jobs:
  generate_plantuml:
    runs-on: ubuntu-latest
    name: plantuml
    steps:
    - uses: actions/checkout@v2
    - name: plantuml
      uses: grassedge/generate-plantuml-action@master
      with:
        path: diagrams
      env:
        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Unfortunately, it does not work on branches other than master, for example on feat/mvpVersion:

Set up job
Run actions/checkout@v2
remote: Counting objects:  94% (18/19)        
Run actions/checkout@v2
Syncing repository: repo
Getting Git version info
Deleting the contents of '/home/runner/work/repo'
Initializing the repository
Disabling automatic garbage collection
Setting up auth
Fetching the repository
Determining the checkout info
Checking out the ref
  /usr/bin/git checkout --progress --force -B feat/mvpVersion refs/remotes/origin/feat/mvpVersion
  Switched to a new branch 'feat/mvpVersion'
  Branch 'feat/mvpVersion' set up to track remote branch 'feat/mvpVersion' from 'origin'.
/usr/bin/git log -1
commit 712a0ef519c421a60cc9f416f29a01f77ddf2e22
Author: Laurent
Date:   Thu Jun 18 19:13:26 2020 +0200

plantuml
    GITHUB_TOKEN: ***
Run grassedge/generate-plantuml-action@master
There are no files to be generated.

Did I miss something, or the generation only works on master?

grassedge pushed a commit that referenced this issue Aug 7, 2020
Add github action workflow for ci testing
@McNultyyy
Copy link

Not sure if you're still seeing this issue but I'm using the following config and it is generating images for all branches.

name: generate plantuml
on:
  push:
    branches:
      - "**"
jobs:
  generate_plantuml: ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants