Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify, simplify, or rewrite IsExposed(member) algorithm #73

Open
glen-84 opened this issue Dec 16, 2024 · 0 comments
Open

Clarify, simplify, or rewrite IsExposed(member) algorithm #73

glen-84 opened this issue Dec 16, 2024 · 0 comments

Comments

@glen-84
Copy link
Contributor

glen-84 commented Dec 16, 2024

Some initial questions:

    • Let {members} be a list of all members across all subgraphs with the same
      coordinate and kind as {member}
    • If any {members} is marked with @internal
      • return false

    According to the spec, @internal can only be applied to field definitions. The spec for IsExposed(member) seems to handle all member types. Can @internal be applied to other member types, or is IsExposed(member) over-specced?

    • If {member} is InputField
    • Let {type} be any input object type that {member} is declared on

    What does "any input object type" mean? The input field would only have one parent input object type, right?

  1. There is no spec for IsExposed(type). If we assume that it just checks for @internal on the input object type, then this also contradicts the specification of the @internal directive, that can only be applied to field definitions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant