Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable "hard-coded" values in declarative eth_calls #5498

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enable "hard-coded" values in declarative eth_calls #5498

wants to merge 1 commit into from

Conversation

incrypto32
Copy link
Member

Closes #5485

@incrypto32 incrypto32 self-assigned this Jun 18, 2024
@incrypto32 incrypto32 force-pushed the incrypto32/hard-coded-values-in-decalred-calls branch from e718a85 to ac4cff1 Compare June 18, 2024 11:05
@fordN fordN requested a review from zorancv June 25, 2024 15:39
zorancv
zorancv approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@zorancv zorancv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chain/ethereum/src/data_source.rs
Some(s) => invalid(s),
None => invalid(s),
let mut parts = s.split('.');
match (parts.next(), parts.next(), parts.next()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mangas mangas mangas approved these changes

@zorancv zorancv zorancv approved these changes

Assignees

@incrypto32 incrypto32

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable "hard-coded" values in declarative eth_calls
3 participants
@incrypto32 @mangas @zorancv