Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Copy/graft should not revert but instead do this #5474

Open
lutter opened this issue Jun 6, 2024 · 0 comments
Open

[Bug] Copy/graft should not revert but instead do this #5474

lutter opened this issue Jun 6, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@lutter
Copy link
Collaborator

lutter commented Jun 6, 2024

Bug report

After all the data for a graft has been copied, we revert the destination to the graft block

For large subgraphs, that will be very slow. Instead of reverting, we should unclamp entity versions while we copy, i.e. instead of blindly copying the block_range from the source, we should insert something like

case when upper(block_range) <= $graft_block then block_range
         else int4range(lower(block_range), null) end as block_range
@lutter lutter added the bug Something isn't working label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant