Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally pass in dependencies #9

Open
hopeyen opened this issue Jul 18, 2023 · 0 comments
Open

Optionally pass in dependencies #9

hopeyen opened this issue Jul 18, 2023 · 0 comments
Labels
meta:triaged This issue has been triaged (has a good description, as well as labels for priority, size and type) p3 Low priority size:medium Medium type:feature New or enhanced functionality

Comments

@hopeyen
Copy link
Collaborator

hopeyen commented Jul 18, 2023

Problem statement
It is useful to be able to know which dependencies are attached to a given POI attestation. This would help us root cause divergence issues.

Expectation proposal
Imagine an Indexer could pass any number of supported dependencies as configuration. If this were a flag, it could take the form:

--dep <type>:<id>=<uri>

poi-radio --dep postgresql:primary=postgresql://host:5432 --dep chain:mainnet=http://geth:8545

For each provided flag, handler logic could be defined for the type that allows POI Radio to extract the version. For example, for the chain type, the POI radio could call web3_clientVersion at the provided uri to get the client version. A SQL statement could similarly be executed to get PostgreSQL version.

The resulting dependency information could be attached to POI messages.

Alternative considerations

  • Utilizes meta field in waku message
  • Expose a route on indexer-service/versions
@hopeyen hopeyen added p3 Low priority type:feature New or enhanced functionality size:medium Medium and removed meta:awaiting-triage labels Sep 18, 2023
@pete-eiger pete-eiger added the meta:triaged This issue has been triaged (has a good description, as well as labels for priority, size and type) label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta:triaged This issue has been triaged (has a good description, as well as labels for priority, size and type) p3 Low priority size:medium Medium type:feature New or enhanced functionality
Projects
None yet
Development

No branches or pull requests

2 participants