Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Faster bootstrap: Skip apt-get update on aws and correct base image #47

Open
lmeyerov opened this issue Mar 7, 2021 · 1 comment
Labels
enhancement New feature or request performance

Comments

@lmeyerov
Copy link
Contributor

lmeyerov commented Mar 7, 2021

Is your feature request related to a problem? Please describe.

Bootstraps are slow to start on aws, with a lot of initial time on:

########################################
+ echo '##'
##
+ echo '## Start: Installing CloudFormation Bootstrap'
## Start: Installing CloudFormation Bootstrap
+ echo '##'
##
+ echo '########################################'
########################################
+ echo

+ echo

+ sudo apt-get update -y

The update is unnecessary because AMIs are updated every 2-4w, and if users are more patch-sensitive, they should be regularly doing their own schedule. ~All other other dependencies should be within the container scripts so not need system ones.

  1. Then, it's slow on:
+ cd ../../docker
+ docker-compose build
The BASE_PATH variable is not set. Defaulting to a blank string.
autoheal uses an image, skipping
Building streamlit
Step 1/20 : ARG DOCKER_TAG=latest
Step 2/20 : ARG GRAPHISTRY_FORGE_BASE_VERSION=latest
Step 3/20 : FROM graphistry/graphistry-forge-base:${GRAPHISTRY_FORGE_BASE_VERSION}
v2.35.9-11.0: Pulling from graphistry/graphistry-forge-base

The pull should be unnecessary. A temporary workaround is basing on forge-etl-python. Even better is if Graphistry explicitly tagsforge-etl-python (which is public container).

Describe the solution you'd like

This should just work :)

Describe alternatives you've considered

Graphistry AMIs can also just start shipping w/ graph-app-kit so most of this goes away

@lmeyerov lmeyerov added enhancement New feature or request performance labels Mar 7, 2021
@lmeyerov
Copy link
Contributor Author

lmeyerov commented Mar 7, 2021

Graphistry 2.36+ now explicitly tags the graphistry-forge-base layer, so that will help future versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request performance
Projects
None yet
Development

No branches or pull requests

1 participant