Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for openmpi #7

Merged
merged 6 commits into from
May 30, 2024

Conversation

dustinswales
Copy link

@grantfirl I think this should do the trick.

@grantfirl
Copy link
Owner

@dustinswales I think that this is OK, although I'm kinda disappointed in being forced to use MPI now. It complicates using the model for something that is not needed, and if running one simple case, it actually slows down execution due to the MPI overhead. In addition, although we could run on login nodes due to the low resource serial job use, we have to use either the batch system or an interactive compute node, at least on Hera. Other platforms may allow running mpirun on the login node. Certainly one's local machine could.

Regardless, this isn't your fault, and I'm going to merge this in because it does fix CI, except for the DEPHY one, which is probably failing due to a different reason.

@grantfirl grantfirl merged commit 7b8ca91 into grantfirl:ufs-dev-PR184 May 30, 2024
17 of 22 checks passed
@dustinswales
Copy link
Author

@grantfirl Yeah, the MPI requirement requires a bit of rework on the host side. The thinking at the time was that requiring the CCPP to use MPI was fine since it was included in spack-stack, and our NCAR/NRL colleagues were fine with this requirement. Plus CCPP is usually embedded within a NWP/GCM which has access to MPI.

The thing that worries me is performance. You mentioned a hit due to the MPI overhead, how big are we talking here?

I need to figure out why the DEPHY test is failing.

@grantfirl
Copy link
Owner

grantfirl commented May 30, 2024 via email

@dustinswales dustinswales deleted the ufs-dev-PR184-djs branch July 1, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants