Skip to content
This repository has been archived by the owner on Sep 10, 2019. It is now read-only.

[Feature Request] Allow user to specify port #35

Open
timrs2998 opened this issue Dec 29, 2017 · 2 comments
Open

[Feature Request] Allow user to specify port #35

timrs2998 opened this issue Dec 29, 2017 · 2 comments

Comments

@timrs2998
Copy link
Contributor

I'd like a -p or --port flag in the CLI to specify the port. I like that get-port has a preferred port option, although port 8080 is a pretty popular port so being able to change the default yarn dev port would be useful for local development and testing.

@jlengstorf
Copy link
Member

I'm onboard with this. We'd effectively just need to add the flag, put it into the env, and check that with a fallback to 8080.

This could be a great first PR for someone — I'll label it and share it around. (Feel free to make the PR yourself as well.)

@timrs2998
Copy link
Contributor Author

awesome thanks; I received that feedback internally and forwarded it as an issue upstream

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants