[tools] Fix QEMU args in gramine-vm.in
#35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimakuv
commented
Jul 16, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion
tools/gramine-vm.in line 103 at r1 (raw file):
else QEMU_MACHINE="-M q35,kernel_irqchip=split,confidential-guest-support=tdx \ -object tdx-guest,id=tdx"
Blocking on this, until re-add with the new name quote-generation-socket and test.
dimakuv
force-pushed
the
dimakuv/fix-for-ubuntu2404
branch
from
8bd78b0 to
3e35814
Compare
QEMU arguments changed a bit in v8.2.1 (used in Ubuntu 24.04). Adjust them in the `gramine-tdx` wrapper script. Signed-off-by: Dmitrii Kuvaiskii <[email protected]>
dimakuv
force-pushed
the
dimakuv/fix-for-ubuntu2404
branch
from
3e35814 to
044937e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
QEMU arguments changed a bit in v8.2.1 (used in Ubuntu 24.04). Adjust them in the
gramine-tdxwrapper script.@dimstav23 helped detecting these issues. Kudos to him.
How to test this PR?
Run
gramine-tdxunder Ubuntu 24.04 and QEMU 8.2.1.This change is