-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI-Examples] Add Candle ML framework example #31
base: intel_tdx
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 8 files reviewed, 1 unresolved discussion
a discussion (no related file):
Blocking comment: these changes must be merged in mainline Gramine, and then Gramine-TDX must be rebased on top of master. Then this PR won't be needed at all -- currently keeping it here for convenience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 9 files reviewed, 2 unresolved discussions
-- commits
line 22 at r2:
Move to separate PR and merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion, "fixup! " found in commit messages' one-liners
Previously, dimakuv (Dmitrii Kuvaiskii) wrote…
Move to separate PR and merge
Done, see #32
dd23d1d
to
e4a50ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 8 files at r1, 3 of 3 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion
7c5301c
to
979ada9
Compare
This is e.g. required by the gemm-common Rust crate, see `gemm-common/src/cache.rs`. Without this file, the crate logic incorrectly calculates shared-cpu count as zero and leads to a division-by-zero exception. Signed-off-by: Dmitrii Kuvaiskii <[email protected]>
Candle is a minimalist ML framework for Rust with a focus on performance and ease of use. This commit adds two examples with Candle: simple matrix multiplication (to quickly test functionality) and Quantized LLaMA (to test performance). Signed-off-by: Dmitrii Kuvaiskii <[email protected]>
979ada9
to
a7fb30c
Compare
Description of the changes
This PR consists of two commits:
shared_cpu_list
file to sysfs cache infoThe latter is a prerequisite for the former.
The Candle app is added for TDX benchmarking purposes. I also submitted the same patches (as two separate PRs) to mainline Gramine:
shared_cpu_list
file to sysfs cache info gramine#1937How to test this PR?
Follow the README of the Candle example.
This change is