Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require / node version of comicgen #33

Open
pratapvardhan opened this issue Aug 19, 2019 · 4 comments
Open

require / node version of comicgen #33

pratapvardhan opened this issue Aug 19, 2019 · 4 comments
Labels
api Create and improve the comicgen API

Comments

@pratapvardhan
Copy link

Enable comicgen to used in require('comicgen') and import('comicgen') environments. Probably default document.currentScript.src to http://gramener.com or /

@sanand0 -- is this something you'd like in this project?

@sanand0
Copy link
Contributor

sanand0 commented Aug 19, 2019

@pratapvardhan What would be some uses of it? Is it to generate the SVG from the server-side? Based on how this would be used, we can prioritize it, and figure out how to structure it.

@sanand0 sanand0 added the api Create and improve the comicgen API label Aug 19, 2019
@pratapvardhan
Copy link
Author

pratapvardhan commented Aug 20, 2019

Yes. For now, I see these two.

  • SVG from the server-side
  • Compatible with observablehq notebooks

Later is my primary motivation.

@sanand0
Copy link
Contributor

sanand0 commented Aug 20, 2019

Got it. I'm not familiar with Observable notebooks -- but that'd be a powerful alternative to what we're doing right now (with Codepen).

Would you like to send a pull request for this, @pratapvardhan? That'll help me understand what code will work. Thanks!

@reezpatel
Copy link

reezpatel commented Nov 23, 2019

A good use case can be to something like this import { Dee } from 'comicgen/react');
Similar same can be implement for various framework. (Angular, Vue etc)

If this is something good to have, i would love to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Create and improve the comicgen API
Projects
None yet
Development

No branches or pull requests

3 participants