-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FrenchRidgeLap #339
base: main
Are you sure you want to change the base?
FrenchRidgeLap #339
Conversation
…into french_ridge_lap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in general looks fine. fix the few docstrings i commented on and let's powwow for 100 seconds with @chenkasirer about the name
…into french_ridge_lap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@obucklin Ready for re-review. I pulled the latest changes from main and made changes based on the feedback.
LGTM |
Implementation of the
FrenchRidgeLap
BTLx process andLFrenchRidgeLapJoint
.In this PR old modules concerning the FRL are being removed as well.
After this PR we can proceed and do a major cleanup of the repo by updating and removing stuff that belonged to the old system of implementation.
What type of change is this?
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.md
file in theUnreleased
section under the most fitting heading (e.g.Added
,Changed
,Removed
).invoke test
).invoke lint
).compas_timber.datastructures.Beam
.