Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FrenchRidgeLap #339

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

FrenchRidgeLap #339

wants to merge 23 commits into from

Conversation

papachap
Copy link
Contributor

image

Implementation of the FrenchRidgeLap BTLx process and LFrenchRidgeLapJoint.
In this PR old modules concerning the FRL are being removed as well.

After this PR we can proceed and do a major cleanup of the repo by updating and removing stuff that belonged to the old system of implementation.

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas_timber.datastructures.Beam.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@papachap papachap linked an issue Nov 27, 2024 that may be closed by this pull request
Copy link
Contributor

@obucklin obucklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in general looks fine. fix the few docstrings i commented on and let's powwow for 100 seconds with @chenkasirer about the name

src/compas_timber/connections/l_french_ridge_lap.py Outdated Show resolved Hide resolved
src/compas_timber/connections/l_french_ridge_lap.py Outdated Show resolved Hide resolved
src/compas_timber/connections/l_french_ridge_lap.py Outdated Show resolved Hide resolved
Copy link
Contributor Author

@papachap papachap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@obucklin Ready for re-review. I pulled the latest changes from main and made changes based on the feedback.

@obucklin
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rework french ridge lap joint
2 participants