added ifc4 and bimwood property set to export settings #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenkasirer
reviewed
Jun 4, 2024
Comment on lines
+43
to
+44
| properties = options.get_ifc_options_properties() | ||
| properties.set_export_bim_wood_property(True) |
There was a problem hiding this comment.
is this global? you don't need to then pass properties to anything?
chenkasirer
reviewed
Jun 4, 2024
| @@ -3,7 +3,7 @@ | |||
| from dataclasses import dataclass | |||
| from typing import List | |||
|
|
|||
| from bim_controller import export_ifc2x3_silently_with_options | |||
| from bim_controller import export_ifc4_silently_with_options | |||
There was a problem hiding this comment.
also please update CHANGELOG.md that we are now using IFC4
chenkasirer
reviewed
Jun 5, 2024
chenkasirer
reviewed
Jun 5, 2024
chenkasirer
reviewed
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the export now follows ifc4 standards and the property set for BIMWood is included in the export, which is a setting incon requires. the ifc file in the zip file shows the correct export.
D1-12.zip