Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: explicitly specify username property in search method #158

Open
wants to merge 1 commit into
base: 4.0.x
Choose a base branch
from

Conversation

boghus
Copy link

@boghus boghus commented May 24, 2024

What the Change Does
🔧 Additional Parameter: We are now explicitly specifying the propertyName as 'username' instead of leaving it null.

In the like method, if propertyName is null, it is set as the result of toPropertyName(paramName). By explicitly providing 'username', we ensure that the propertyName used in the search is exactly 'username'.

✨ Clarity Improvement: This change is useful if paramName and propertyName can be different in some context, but in this specific case, we are only making explicit what was already being done implicitly.

Impact of the Change
📝 Clarity: It makes it more explicit that the username field is both the parameter name and the property name to search.
⚙️ Functionality: This should not change functionality in this specific case because toPropertyName('username') was likely already returning 'username'.

@CLAassistant
Copy link

CLAassistant commented May 24, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants