Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.1.3 Logging - make it clear that grails-logging plugin required for auto log-injection #598

Open
amcclain opened this issue Aug 3, 2017 · 1 comment

Comments

@amcclain
Copy link

amcclain commented Aug 3, 2017

http://docs.grails.org/3.3.x/guide/conf.html#logging

Without the grails-logging plugin, Grails artifacts do not get a log property auto-injected as the docs state. Instead, you would need to annotate your classes manually with the @Slf4j annotation.

For users who might be upgrading apps and not starting from a blank create-app template (where the plugin is inserted for you), I think it would be useful to call out the dependency right in the logging docs.

We also use the grails-dependencies POM in our apps to bundle up the "core" deps - perhaps the logging plugin should be added to that as well?

Of course, let me know if I am misunderstanding anything here!

@sdelamo
Copy link
Contributor

sdelamo commented Oct 31, 2017

We have created a github repository with comparisions between different grails versions to ease upgrade.

For example, if you are upgrading from 3.2.11 to 3.3.1 you can see the changes:

grails-profiles-versions/web-versions@3.2.11...3.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants