Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: toHaveAlert has an incorrect return type #1010

Closed
academo opened this issue Jul 15, 2024 · 1 comment
Closed

Bug: toHaveAlert has an incorrect return type #1010

academo opened this issue Jul 15, 2024 · 1 comment
Assignees
Labels
plugin-e2e related to the plugin-e2e package

Comments

@academo
Copy link
Member

academo commented Jul 15, 2024

when using toHaveAlert the linter reports await has no effect but it is an async function that requires alert

image

https://github.com/grafana/plugin-tools/blob/main/packages/plugin-e2e/src/matchers/toHaveAlert.ts#L7

@sunker
Copy link
Contributor

sunker commented Aug 21, 2024

Fixed in #1070

@sunker sunker closed this as completed Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin-e2e related to the plugin-e2e package
Projects
Development

No branches or pull requests

2 participants