Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non ASCII characters in topic names not handled well when creating datasource channel id #87

Open
barskern opened this issue Nov 8, 2023 · 1 comment

Comments

@barskern
Copy link

barskern commented Nov 8, 2023

If a topic contains a non-ascii character, that character has to be removed or changed prior to creating a channel id. When the topic is used directly that means that any topic with such characters is invalid. Particularly, this is annoying if you want to monitor any builtin topics from MQTT such as $SYS/broker/....

Channel ID requirements detailed here.

Location in this codebase where invalid channel ID is created.

@Nocccer
Copy link

Nocccer commented Feb 11, 2024

The problem is that grafana query to backend datasources do not allow this characters. They also do not allow + and #.

I added support for this two characters by changing them in the frontend to something like __PLUS and __HASH and in the backend reverted this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants