[tempo-distributed] Allow prefixing of rollout-group value and ingester name #3443
+33
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boldfield
requested review from
Sheikh-Abubaker,
mapno,
swartz-k,
BitProcessor and
faustodavid
as code owners
|
|
boldfield
force-pushed
the
boldfield/allow-prefixing-tempo-rollout-group
branch
4 times, most recently
from
dbba1fc to
e19aa4e
Compare
boldfield
changed the title
boldfield
force-pushed
the
boldfield/allow-prefixing-tempo-rollout-group
branch
2 times, most recently
from
c82231a to
a975fa1
Compare
boldfield
force-pushed
the
boldfield/allow-prefixing-tempo-rollout-group
branch
from
a975fa1 to
3901a73
Compare
boldfield
force-pushed
the
boldfield/allow-prefixing-tempo-rollout-group
branch
6 times, most recently
from
62fda25 to
ca4e7c7
Compare
boldfield
force-pushed
the
boldfield/allow-prefixing-tempo-rollout-group
branch
from
ca4e7c7 to
9fdf4d9
Compare
Signed-off-by: Brian Oldfield <[email protected]>
Signed-off-by: Brian Oldfield <[email protected]>
Signed-off-by: Brian Oldfield <[email protected]>
boldfield
force-pushed
the
boldfield/allow-prefixing-tempo-rollout-group
branch
from
9fdf4d9 to
b539ef7
Compare
|
The corollary of this PR for the Loki charts has been merged: grafana/loki#15063 |
|
I'm concerned about the complexity this adds to the chart. I would strongly advise not running both Loki and Tempo in the same namespace. Is there a reason to put them in one? |
|
@joe-elliott we have constraints within our environment that require running the entire LTGM stack in a single namespace and are actively doing it. These changes are opt-in so they will not add additional complexity w/r to users who do not opt to use the feature. |
|
I also have an alternative solution that can be found here: grafana/rollout-operator#190 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for prefixing both the
rollout-grouplabel,namelabel, and serviceName of the Tempo Ingester StatefulSet, when running in distributed mode, to avoid scheduling and rollout issues when deploying multiple elements of the LTGM stack to a single namespace.Fixes #3442