Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legend displays some selected properties inconsistently #164

Open
fridgepoet opened this issue Feb 7, 2023 · 6 comments
Open

Legend displays some selected properties inconsistently #164

fridgepoet opened this issue Feb 7, 2023 · 6 comments
Labels
datasource/TwinMaker help wanted Extra attention is needed type/bug Something isn't working

Comments

@fridgepoet
Copy link
Member

fridgepoet commented Feb 7, 2023

What happened:
Some weird behavior around the Legend: sometimes choosing "Temperature," for example, causes "Temperature" to just continue displaying on the legend, even if it is a duplicate.

Screen.Recording.2023-05-10.at.11.24.16.mov

What you expected to happen:
It should show the properties which were selected.

How to reproduce it (as minimally and precisely as possible):
See the above screen recording on https://play.grafana.org/d/TRA53ITVz/main-dashboard?orgId=1
Play around with the Selected Properties, removing them, adding them back -- you should see the the inconsistent behavior.
For example, selecting Mixer entity > Temperature + RPM Properties in the same query only displays Temperature twice on the panel. However if you choose RPM alone, Temperature still displays.

Environment:

  • Grafana version: 9.5.2-cloud
  • Plugin version:
@fridgepoet fridgepoet added type/bug Something isn't working datasource/TwinMaker labels Feb 7, 2023
@github-project-automation github-project-automation bot moved this to Incoming in AWS Datasources Feb 7, 2023
@fridgepoet fridgepoet changed the title Multiple "Selected Properties" in query editor not displaying Multiple "Selected Properties" are incorrectly duplicated in legend Feb 7, 2023
@fridgepoet fridgepoet moved this from Incoming to Backlog in AWS Datasources Feb 7, 2023
@iwysiu
Copy link
Contributor

iwysiu commented Feb 7, 2023

Interesting, I tried repro-ing this on both play grafana and locally, and what I got was it just returning the data for the first property. Which is still a bug, but a slightly different one.

@taleena
Copy link
Collaborator

taleena commented May 9, 2023

Working on a test environment to figure out where this bug lives.

@fridgepoet fridgepoet changed the title Multiple "Selected Properties" are incorrectly duplicated in legend Multiple "Selected Properties" are incorrectly displaying in legend May 10, 2023
@fridgepoet fridgepoet changed the title Multiple "Selected Properties" are incorrectly displaying in legend Legend displays some selected properties incorrectly May 10, 2023
@fridgepoet fridgepoet changed the title Legend displays some selected properties incorrectly Legend displays some selected properties inconsistently May 10, 2023
@fridgepoet
Copy link
Member Author

@taleena I've tried to reproduce on play.grafana.org and it's not quite what I described.
I've updated the description with a video recording of what I observed and you should be able to use https://play.grafana.org/d/TRA53ITVz/main-dashboard?orgId=1 to have a look.

@taleena
Copy link
Collaborator

taleena commented Jul 18, 2023

Per TM team, seems this could be an issue with the times series panel, or in the way TM is sending the query in the backend and we should take a look there.

@taleena taleena added the help wanted Extra attention is needed label Sep 12, 2023
@katebrenner
Copy link
Contributor

Grafana + Twinmaker team to collab on this

@taleena
Copy link
Collaborator

taleena commented Sep 24, 2024

Try to repro in a newer version - there haven't been customer/user complaints thus far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasource/TwinMaker help wanted Extra attention is needed type/bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

4 participants