Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update helm charts to reflect latest map pinning changes #1261

Open
Tracked by #1144
rafaelroquetto opened this issue Oct 15, 2024 · 3 comments · May be fixed by #1273
Open
Tracked by #1144

Update helm charts to reflect latest map pinning changes #1261

rafaelroquetto opened this issue Oct 15, 2024 · 3 comments · May be fixed by #1273

Comments

@rafaelroquetto
Copy link
Contributor

#1251 removed the requirement for map pinning using the bpf filesystem. We need to update our helm charts to reflect that change, in particular, removing the parts that set up the bpf filesystem mounts.

@marevers
Copy link
Contributor

marevers commented Oct 23, 2024

@rafaelroquetto I can take a look at doing this - I assume from /charts/beyla/templates/daemon-set.yaml we can remove the entire init container, the bpffs volume mount/volume and the BEYLA_BPF_FS_PATH / BEYLA_BPF_FS_BASE_DIR environment variables?

@grcevski
Copy link
Contributor

That would be awesome @marevers. You are correct, the BPF mount is not needed at all and it was the only reason for the init container.

@marevers
Copy link
Contributor

Thanks. I've linked the PR with the removal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants