Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch logback >= 1.3 to require slf4j >= 2.0, logback < 1.3 to require slf4j <= 1.7.x #122

Open
tbroyer opened this issue Apr 16, 2024 · 1 comment · May be fixed by #123
Open

Patch logback >= 1.3 to require slf4j >= 2.0, logback < 1.3 to require slf4j <= 1.7.x #122

tbroyer opened this issue Apr 16, 2024 · 1 comment · May be fixed by #123
Assignees
@ljacomet
Labels
a:rule One or more metadata rules that should be added or updated in:logging Things related to 'logging { }' DSL

Comments

@tbroyer
Copy link

tbroyer commented Apr 16, 2024

Slf4j 2 is a major breaking change (uses ServiceLoader rather than "static binder mechanism"), and Logback migrated to Slf4j 2 in version 1.3.

When working on tests for a PR for #106, I could have had slf4j 2 with logback 1.2, and these are actually incompatible (https://slf4j.org/faq.html#changesInVersion200) so it would be great if the plugin could prevent such situations.

The documentation for Logback says versions <= 1.2 “[have] been deprecated for several years and [are] no longer actively developed”, so maybe existing tests should just upgrade to slf4j 2 and logback 1.3 or 1.5 (depending on JDK requirements, maybe 1.5 and JDK 11 are OK for tests), or maybe they should be duplicated for slf4j 1.7 (with logback 1.2) and slf4j 2.0 (with logback 1.3 or 1.5).
@tbroyer tbroyer linked a pull request Apr 17, 2024 that will close this issue
Draft
@jjohannes jjohannes added the in:logging Things related to 'logging { }' DSL label Apr 23, 2024
@britter britter added the a:rule One or more metadata rules that should be added or updated label Apr 26, 2024
@ljacomet
Copy link
Contributor

Indeed, full support for slf4j 2 was never added. I still need to take a look at your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ljacomet ljacomet

Labels
a:rule One or more metadata rules that should be added or updated in:logging Things related to 'logging { }' DSL
Projects
None yet
Milestone
No milestone
4 participants
@ljacomet @tbroyer @britter @jjohannes