Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requireAllDefinedDependencies: avoid running the same transform many times #137

Closed
jjohannes opened this issue Sep 2, 2024 · 0 comments · Fixed by #142
Closed

requireAllDefinedDependencies: avoid running the same transform many times #137

jjohannes opened this issue Sep 2, 2024 · 0 comments · Fixed by #142
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jjohannes
Copy link
Member

jjohannes commented Sep 2, 2024

With the current approach, the input to the transformation is different for each subproject due to different classpaths this leads to the transformation running multiple times producing multiple Jar files (with the same content). If we always give the metadata for all defined dependencies that shall be patched as input, the input should be the same as long as all subproject use the same plugin configuration.

multiple

It basically means that we should return the full list here instead of filtering it based on the current projects classpaths.

@jjohannes jjohannes added the enhancement New feature or request label Sep 2, 2024
@jjohannes jjohannes added this to the 1.9 milestone Sep 2, 2024
@jjohannes jjohannes self-assigned this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant