Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support addressing classified Jar via coordinates #130

Closed
jjohannes opened this issue Jul 8, 2024 · 3 comments · Fixed by #146
Closed

Support addressing classified Jar via coordinates #130

jjohannes opened this issue Jul 8, 2024 · 3 comments · Fixed by #146
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jjohannes
Copy link
Member

jjohannes commented Jul 8, 2024

For example, to patch io.netty:netty-transport-native-epoll with classifier linux-x86_64 you have to use the file name:

module("netty-transport-native-epoll-4.1.87.Final-linux-x86_64.jar", "io.netty.transport.epoll.linux.x86_64")

It should be possible to do it like this:

module("io.netty:netty-transport-native-epoll|linux-x86_64", "io.netty.transport.epoll.linux.x86_64")
@jjohannes
Copy link
Member Author

Related: #129

@Vampire
Copy link

Vampire commented Jul 8, 2024

It should be possible to do it like this:

Don't forget a version for version-catalog accessor usage :-)
Maybe a viable alternative: module("io.netty:netty-transport-native-epoll", "io.netty.transport.epoll.linux.x86_64") { classifier = "linux-x86_64" } or something like that.

@jjohannes jjohannes added this to the 1.9 milestone Sep 16, 2024
@jjohannes
Copy link
Member Author

The feature is implemented with the notation proposed in the description. Follwoing the same "identifier" notation used in java-module-dependencies.

Generally, I would agree that we do to much "special" strings instead of a nicer DSL. For now, I want to stay consistent with things we already have in this and the other GradleX Modules Plugins.

Maybe something to revisit if we should do a 2.x with a reworked DSL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants