Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customization of PACKAGE_NAME, PLUGIN_CLASS_NAME, GENERATED_EXTENSION_NAME, GENERATED_EXTENSION_CLASS_NAME #137

Open
yogurtearl opened this issue Aug 16, 2023 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@yogurtearl
Copy link

If I want to modularize or have multiple generated build-parameters plugins that get pulled into the same build, I need to customize PACKAGE_NAME, PLUGIN_CLASS_NAME, GENERATED_EXTENSION_NAME, GENERATED_EXTENSION_CLASS_NAME to avoid namespace clashes.

String PACKAGE_NAME = "buildparameters";
String PLUGIN_CLASS_NAME = "GeneratedBuildParametersPlugin";
String GENERATED_EXTENSION_NAME = "buildParameters";
String GENERATED_EXTENSION_CLASS_NAME = "BuildParametersExtension";

Similar to how the plugin id is customizable, I would like to be able to customize those as well.

Generating multiple build-parameters plugins and composing them could address some issues like these (also, built-in support would probably be preferred in these cases):

@jjohannes
Copy link
Member

Thank you for reporting this @yogurtearl. I agree that these should be configurable, similar to how the plugin id is configurable. Lets see that we do this for the next release.

@jjohannes jjohannes added the enhancement New feature or request label Sep 1, 2023
@jjohannes jjohannes added this to the 1.5 milestone Sep 1, 2023
@britter
Copy link
Member

britter commented Sep 21, 2023

@yogurtearl what are your thought about #114? Would this solve your use case? The idea is export the definitions using dependency management and then combine them in a single plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants