Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Play 2.7 #92

Closed
apflieger opened this issue Apr 12, 2019 · 24 comments
Closed

Support for Play 2.7 #92

apflieger opened this issue Apr 12, 2019 · 24 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@apflieger
Copy link

Using

play {
    platform {
        playVersion = '2.7.0'
    }
}

I get Not a supported Play version: 2.7.0. This plugin is compatible with: [PLAY_2_3_X, PLAY_2_4_X, PLAY_2_5_X, PLAY_2_6_X].

:)

@bmuschko
Copy link
Contributor

The currently supported Play versions are documented in the user guide. Play 2.7 is not supported yet. I am hoping that we can add support for newer Play versions as soon as we have more adopters for this plugin.

@bmuschko bmuschko added the enhancement New feature or request label Apr 12, 2019
@apflieger
Copy link
Author

apflieger commented Apr 12, 2019

To be sure, there's no way to build Play 2.7 on gradle right now, right? I tried the legacy plugin which fails with the same error

@bmuschko
Copy link
Contributor

bmuschko commented Apr 12, 2019

That's correct. The old and the new plugin have almost identical feature sets at the moment. The main difference is:

  • old plugin: uses the software model and is included in the Gradle distribution
  • new plugin: does not use the software model and is distributed via the Gradle plugin portal

Additionally, you might want to check out this migration portion of the guide.

@aadrian
Copy link

aadrian commented Jul 21, 2019

Any news on this issue?

( 2.8.0 is already around the corner https://github.com/playframework/playframework/releases/tag/2.8.0-M3 )

Thank you.

@bmuschko
Copy link
Contributor

@big-guy Can you comment on the plans for this?

@arjunchhabra
Copy link

Hi all. Any updates on this item? @big-guy / @bmuschko

@JLLeitschuh JLLeitschuh added the good first issue Good for newcomers label Sep 11, 2019
@wooyea
Copy link

wooyea commented Dec 6, 2019

Hi all. Any updates on this item? @big-guy / @bmuschko

latest snapshot works for me

@aadrian
Copy link

aadrian commented Dec 6, 2019

@wooyea does it also work with 2.8.0 ?

@wooyea
Copy link

wooyea commented Dec 14, 2019

@wooyea does it also work with 2.8.0 ?

Probably not. Supported version prefix was hardcoded.

@aadrian
Copy link

aadrian commented Dec 14, 2019

@wooyea thanks for the info.

It's a pity since Play 2.8 has just been released :( .

@ricardo-s-ferreira
Copy link

ricardo-s-ferreira commented Jan 30, 2020

Do you have any forecast for release date?
We are locked in version 2.6. we need to upgrade. if we don't have this we have to use SBT.

@hallyhaa
Copy link

hallyhaa commented Feb 5, 2020

[...] I am hoping that we can add support for newer Play versions as soon as we have more adopters for this plugin.

I think it's the other way around: you'll get more adopters as soon as the plugin supports the newest play versions. (I typically would like to test it with the newest play version before even thinking of using it anywhere.)

Vicious circle, this?

@apflieger
Copy link
Author

Here I even considered downgrading Play to use this plugin

@ricardo-s-ferreira
Copy link

ricardo-s-ferreira commented Feb 5, 2020 via email

@polentino
Copy link

The currently supported Play versions are documented in the user guide. Play 2.7 is not supported yet. I am hoping that we can add support for newer Play versions as soon as we have more adopters for this plugin.

Given that's been more than a year since Play 2.7.0 was first released, and now there's even 2.8 available, would it be possible to update the plugin to support 2.7?

@ricardo-s-ferreira
Copy link

No one will adopters this since doesn't support 2.8. who will start using this with play 2.5, or even 2.6 not fully supported?
I just remove from our project.
RIP.

@benmccann
Copy link

I sent a PR for Play 2.8 support: #133

@devYonz
Copy link

devYonz commented Jul 18, 2020

I have spent the majority of the last 3 hours trying to keep Gradle, how is this still not solved? We need:

  • Code samples: Play 2.8 + Gradle plugin (in the current non-software model)
  • Latest Gradle v7 is coming + Gradle plugin + Java 14 should all play nice together until play framework starts supporting java 14
    It is only my spite for sbt that is keeping me here, even the play docs are starting to only use sbt.

@polentino
Copy link

polentino commented Jul 18, 2020

It is only my spite for sbt that is keeping me here, even the play docs are starting to only use sbt.

same here.

@bmuschko / @big-guy any idea if support for 2.7 will ever land? At some point, we devs would like to have a definitive [yes, no] answer so that we can proper decisions on the projects we will start

@JLLeitschuh
Copy link
Contributor

I'm happy to merge changes once #136 is resolved. Currently, I can't really trust the CI to verify if a change will break anything. Once I have confidence in CI, I'll be more confident merging external PRs.

@bmuschko
Copy link
Contributor

@polentino Unfortunately, I am not involved in the project anymore. Cheers!

@JLLeitschuh
Copy link
Contributor

Support is requested on #136. If you'd like to see this issue resolved, please do help out with resolving #136.

@cstroe
Copy link
Contributor

cstroe commented Sep 12, 2020

See #147 for a fix to #136

@JLLeitschuh
Copy link
Contributor

This has been resolved in v0.10

https://gradle.github.io/playframework/#change_log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests