Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToolChain #178

Open
Jonatha1983 opened this issue Aug 8, 2022 · 0 comments
Open

ToolChain #178

Jonatha1983 opened this issue Aug 8, 2022 · 0 comments

Comments

@Jonatha1983
Copy link

Hi again

I dive in the plugin a bit and compare it to other gradle plugins (spring boot) and other gradle plugins look like it require quite a bit of refactoring:

  1. The runPlay should extend from JavaExec - and should take in consideration the ToolChain configuration
  2. The forkOption is not properly configurable and each time a RunPlay instance is created it is set to new BaseOptions - instead of using the lazy property configuration
  3. Server and Client WorkProcess are not properly configured when created looks like not all running JVM are properly delegated to those process
  4. Multiple use of deprecated api
  5. More...

I am willing to contribute to this plugin but I will need some mentoring and some references from someone from the Gradle team.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant